]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ethtool: fix the error condition in ethtool_get_phy_stats_ethtool()
authorSu Hui <suhui@nfschina.com>
Wed, 5 Jun 2024 03:47:43 +0000 (11:47 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 11 Jan 2026 14:19:27 +0000 (15:19 +0100)
commitf9e57e7ca77393b5b7072800370370b02eaad0f8
treee73d5e0ccc9a341deeb62c82b8a8853185a18e35
parent45410637fae052202164175569f54cbf32cdc81a
net: ethtool: fix the error condition in ethtool_get_phy_stats_ethtool()

commit 0dcc53abf58d572d34c5313de85f607cd33fc691 upstream.

Clang static checker (scan-build) warning:
net/ethtool/ioctl.c:line 2233, column 2
Called function pointer is null (null dereference).

Return '-EOPNOTSUPP' when 'ops->get_ethtool_phy_stats' is NULL to fix
this typo error.

Fixes: 201ed315f967 ("net/ethtool/ioctl: split ethtool_get_phy_stats into multiple helpers")
Signed-off-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Hariprasad Kelam <hkelam@marvell.com>
Link: https://lore.kernel.org/r/20240605034742.921751-1-suhui@nfschina.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ethtool/ioctl.c