]> git.ipfire.org Git - thirdparty/linux.git/commit
media: ov2740: Don't log ov2740_check_hwcfg() errors twice
authorHans de Goede <hdegoede@redhat.com>
Sat, 12 Oct 2024 16:08:03 +0000 (18:08 +0200)
committerHans Verkuil <hverkuil@xs4all.nl>
Thu, 7 Nov 2024 08:05:56 +0000 (09:05 +0100)
commitfa0611dce6f9fe903ae3fa60247f7e83868091df
tree4bb756b833229b076c06fc1eab27ea8f988549ef
parentc7ccf3683ac9746b263b0502255f5ce47f64fe0a
media: ov2740: Don't log ov2740_check_hwcfg() errors twice

All ov2740_check_hwcfg() error-exit paths already log a detailed reason,
logging a second generic "failed to check HW configuration" error is
not useful, drop this.

The one exception is the -EPROBE_DEFER exit on
fwnode_graph_get_next_endpoint() returning NULL.

Call dev_err_probe() there to register the reason for deferring the probe,
this is used if the endpoint is still not there after 30 seconds, e.g. :

 i2c-INT3474:00: deferred probe pending: waiting for fwnode graph endpoint

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/i2c/ov2740.c