]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
perf: Reject exited events as group leaders
authorKyle Zeng <kylebot@openai.com>
Thu, 6 Aug 2026 20:56:55 +0000 (13:56 -0700)
committerPeter Zijlstra <peterz@infradead.org>
Fri, 7 Aug 2026 16:27:04 +0000 (18:27 +0200)
commitfa091f46c3833fb22384f10eade2b4e1e1d0b278
tree727c610232112f4ce819b1a5af554b772a3cd8aa
parent075b74841bd0065a3bda3440873c747938e69b68
perf: Reject exited events as group leaders

perf_event_remove_on_exec() sets remove-on-exec events to the EXIT state
and detaches their group relationships.  The event's file descriptor can
remain open, however, and perf_event_open() currently accepts that event
as a group leader because its early validation rejects only REVOKED and
DEAD events.

A new sibling can consequently be linked to the detached leader.  When
the leader is closed, perf_group_detach() observes that its
PERF_ATTACH_GROUP bit is already clear and skips the new sibling.  The
sibling then retains a group_leader pointer to the freed event.

Reject group leaders in the EXIT state.  Perform the check while holding
the shared context mutex so that an exec in the target task cannot detach
the leader between validation and group attachment.

[peterz: make the earlier test fully consistent]
Fixes: 037a3c43edfb ("perf/core: Detach event groups during remove_on_exec")
Assisted-by: Codex:gpt-5.6-sol
Signed-off-by: Kyle Zeng <kylebot@openai.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://patch.msgid.link/20260806205655.75722-1-kylebot@openai.com
kernel/events/core.c