]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
PCI: cadence-ep: Fix the driver to send MSG TLP for INTx without data payload
authorHans Zhang <18255117159@163.com>
Fri, 14 Feb 2025 16:57:24 +0000 (00:57 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Apr 2025 12:31:58 +0000 (14:31 +0200)
commitfa2fcc7706feb7b3123d63f54d5b524c54ab1242
treef3d9a8e89bf8f4a7690cdfc1ea4df1c3435c4c10
parente5cd58f61e9d8024ee11bd78c12c8916891d4077
PCI: cadence-ep: Fix the driver to send MSG TLP for INTx without data payload

[ Upstream commit 3ac47fbf4f6e8c3a7c3855fac68cc3246f90f850 ]

Per the Cadence's "PCIe Controller IP for AX14" user guide, Version
1.04, Section 9.1.7.1, "AXI Subordinate to PCIe Address Translation
Registers", Table 9.4, the bit 16 of the AXI Subordinate Address
(axi_s_awaddr) when set corresponds to MSG with data, and when not set,
to MSG without data.

However, the driver is currently doing the opposite and due to this,
the INTx is never received on the host.

So, fix the driver to reflect the documentation and also make INTx work.

Fixes: 37dddf14f1ae ("PCI: cadence: Add EndPoint Controller driver for Cadence PCIe controller")
Signed-off-by: Hans Zhang <18255117159@163.com>
Signed-off-by: Hans Zhang <hans.zhang@cixtech.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20250214165724.184599-1-18255117159@163.com
[kwilczynski: commit log]
Signed-off-by: Krzysztof WilczyƄski <kwilczynski@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/controller/cadence/pcie-cadence-ep.c
drivers/pci/controller/cadence/pcie-cadence.h