]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: usb-audio: Remove unneeded wmb() in mixer_quirks
authorCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Mon, 26 May 2025 14:07:47 +0000 (17:07 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Oct 2025 11:35:44 +0000 (13:35 +0200)
commitfa36132dcedc4a27db1d844040af6a75fd0c0f8f
tree02debceabcd6bee6aeb9571634f22071893c92ae
parenta6a3d31a01fb93d76731cf22896c6d8823fb5851
ALSA: usb-audio: Remove unneeded wmb() in mixer_quirks

[ Upstream commit 9cea7425595697802e8d55a322a251999554b8b1 ]

Adding a memory barrier before wake_up() in
snd_usb_soundblaster_remote_complete() is supposed to ensure the write
to mixer->rc_code is visible in wait_event_interruptible() from
snd_usb_sbrc_hwdep_read().

However, this is not really necessary, since wake_up() is just a wrapper
over __wake_up() which already executes a full memory barrier before
accessing the state of the task to be waken up.

Drop the redundant call to wmb() and implicitly fix the checkpatch
complaint:

  WARNING: memory barrier without comment

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250526-dualsense-alsa-jack-v1-8-1a821463b632@collabora.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/usb/mixer_quirks.c