]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
hypfs: Fix error number left in struct pointer member
authorDavid Howells <dhowells@redhat.com>
Thu, 21 Mar 2019 10:08:08 +0000 (10:08 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 10 Dec 2019 18:01:21 +0000 (18:01 +0000)
commitfa4fb29a16694477c90b9352f247b7a06b35462e
tree799f0a4529d7661587f157d788c02ffcb9fd8009
parentd7f400b8cabb95604f084571927845651f110f6a
hypfs: Fix error number left in struct pointer member

commit b54c64f7adeb241423cd46598f458b5486b0375e upstream.

In hypfs_fill_super(), if hypfs_create_update_file() fails,
sbi->update_file is left holding an error number.  This is passed to
hypfs_kill_super() which doesn't check for this.

Fix this by not setting sbi->update_value until after we've checked for
error.

Fixes: 24bbb1faf3f0 ("[PATCH] s390_hypfs filesystem")
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
cc: Heiko Carstens <heiko.carstens@de.ibm.com>
cc: linux-s390@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/s390/hypfs/inode.c