]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
iommu/iova: Add NULL check in iova_magazine_free()
authorlynn <liulynn@google.com>
Sat, 14 Feb 2026 08:09:19 +0000 (08:09 +0000)
committerJoerg Roedel <joerg.roedel@amd.com>
Tue, 17 Mar 2026 12:28:37 +0000 (13:28 +0100)
commitfa8fb60d36375ca3166a60589a624f0d0bc9ddb5
tree646d6ae17b6c0d929eb4934e31eb13197a46648b
parent199036ae01321651fe0e4488f9e19a28af4c5f1d
iommu/iova: Add NULL check in iova_magazine_free()

When iova_domain_init_rcaches() fails to allocate an iova_magazine
during the initialization of per-cpu rcaches, it jumps to out_err and
calls free_iova_rcaches() for cleanup.

In free_iova_rcaches(), the code iterates through all possible CPUs to
free both cpu_rcache->loaded and cpu_rcache->prev. However, if the
original allocation failed mid-way through the CPU loop, the pointers
for the remaining CPUs remain NULL.

Since kmem_cache_free() does not explicitly handle NULL pointers like
kfree() does, passing these NULL pointers leads to a kernel paging
request fault.

Add a NULL check in iova_magazine_free() to safely handle partially
initialized rcaches in error paths.

Signed-off-by: lynn <liulynn@google.com>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
drivers/iommu/iova.c