]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
[3.14] gh-133982: Run unclosed file test on all io implementations (gh-134165) (gh...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 21 May 2025 15:22:44 +0000 (17:22 +0200)
committerGitHub <noreply@github.com>
Wed, 21 May 2025 15:22:44 +0000 (17:22 +0200)
commitfade04e0f441be0ea3ec0ef99dd0af8113df9ed8
treefdd86645c540b0337cc78af78aa66bfb0b902bd8
parent74dde92903769b77843152a3603f0e50845ccc81
[3.14] gh-133982: Run unclosed file test on all io implementations (gh-134165) (gh-134433)

Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch to
different I/O implementations.

Update the `_pyio` implementation to match expected behavior, using the
same `_dealloc_warn` design as the C implementation uses to report the
topmost `__del__` object.

The FileIO one now matches all the others, so can use IOBase. There was
a missing check on closing (self._fd must be valid), add that check
(cherry picked from commit 5b0e82752120a5dc66ce6ee778751d71ba2c33b2)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
Lib/_pyio.py
Lib/test/test_io.py
Misc/NEWS.d/next/Library/2025-05-17-20-23-57.gh-issue-133982.smS7au.rst [new file with mode: 0644]