]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix privilege checks for pg_prewarm() on indexes.
authorNathan Bossart <nathan@postgresql.org>
Fri, 17 Oct 2025 16:36:50 +0000 (11:36 -0500)
committerNathan Bossart <nathan@postgresql.org>
Fri, 17 Oct 2025 16:36:50 +0000 (11:36 -0500)
commitfae0ce5e318eea8cd8f7bac936a58ee7cbd10bf8
tree10e7bf891669f16b2cd33c786a86b5cc995bb6b4
parentbf5b26525b28a2abf8eef368921c12fdeaddc0d8
Fix privilege checks for pg_prewarm() on indexes.

pg_prewarm() currently checks for SELECT privileges on the target
relation.  However, indexes do not have access rights of their own,
so a role may be denied permission to prewarm an index despite
having the SELECT privilege on its parent table.  This commit fixes
this by locking the parent table before the index (to avoid
deadlocks) and checking for SELECT on the parent table.  Note that
the code is largely borrowed from
amcheck_lock_relation_and_check().

An obvious downside of this change is the extra AccessShareLock on
the parent table during prewarming, but that isn't expected to
cause too much trouble in practice.

Author: Ayush Vatsa <ayushvatsa1810@gmail.com>
Co-authored-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Jeff Davis <pgsql@j-davis.com>
Discussion: https://postgr.es/m/CACX%2BKaMz2ZoOojh0nQ6QNBYx8Ak1Dkoko%3DD4FSb80BYW%2Bo8CHQ%40mail.gmail.com
Backpatch-through: 13
contrib/pg_prewarm/pg_prewarm.c
contrib/pg_prewarm/t/001_basic.pl