]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
firmware: qcom_scm: Fix error retval in __qcom_scm_is_call_available()
authorGuru Das Srinagesh <quic_gurus@quicinc.com>
Mon, 11 Oct 2021 20:00:14 +0000 (13:00 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Nov 2021 10:04:28 +0000 (11:04 +0100)
commitfae72275217d6c2c4d64dfb4cde47c24c4eba38a
tree49cfb76e04584861a22c82c92695e68e66e1aaf9
parent61bb3fac7a56c9d43422a8af39a681e39f5ef936
firmware: qcom_scm: Fix error retval in __qcom_scm_is_call_available()

[ Upstream commit 38212b2a8a6fc4c3a6fa99d7445b833bedc9a67c ]

Since __qcom_scm_is_call_available() returns bool, have it return false
instead of -EINVAL if an invalid SMC convention is detected.

This fixes the Smatch static checker warning:

drivers/firmware/qcom_scm.c:255 __qcom_scm_is_call_available()
warn: signedness bug returning '(-22)'

Fixes: 9d11af8b06a8 ("firmware: qcom_scm: Make __qcom_scm_is_call_available() return bool")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guru Das Srinagesh <quic_gurus@quicinc.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/1633982414-28347-1-git-send-email-quic_gurus@quicinc.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/firmware/qcom_scm.c