]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ice: cleanup capabilities evaluation
authorDave Ertman <david.m.ertman@intel.com>
Mon, 16 Jun 2025 11:03:21 +0000 (13:03 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Thu, 14 Aug 2025 15:57:28 +0000 (08:57 -0700)
commitfb2f2a86f0cd9690357b9bb67af00d386a7e819f
treee728cd0fdf6d82feb1cb297502107d4f2b587469
parent148c8cb32b2f4a32c4b47998da20f2fd62cc38ca
ice: cleanup capabilities evaluation

When evaluating the capabilities field, the ICE_AQC_BIT_ROCEV2_LAG and
ICE_AQC_BIT_SRIOV_LAG defines were both not using the BIT operator,
instead simply setting a hex value that set the correct bits.  While
not inaccurate, this method is misleading, and when it is expanded in
the following implementation it becomes even more confusing.

Switch to using the BIT() operator to clarify what is being checked.

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com>
Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
include/linux/net/intel/libie/adminq.h