]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Avoid platform-specific null pointer dereference in psql.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 25 Aug 2019 19:04:04 +0000 (15:04 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 25 Aug 2019 19:04:04 +0000 (15:04 -0400)
commitfb55e95396caa5f03dc37f72522313eb5c095ee1
tree24a4fb6dd6db56c1302dbb68f5bf78fde7d38896
parent1fb2d78cb94672f4cfc0c1a2da9e0a534e3698f2
Avoid platform-specific null pointer dereference in psql.

POSIX permits getopt() to advance optind beyond argc when the last
argv entry is an option that requires an argument and hasn't got one.
It seems that no major platforms actually do that, but musl does,
so that something like "psql -f" would crash with that libc.
Add a check that optind is in range before trying to look at the
possibly-bogus option.

Report and fix by Quentin Rameau.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/20190825100617.GA6087@fifth.space
src/bin/psql/startup.c