]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iio: mma8452: Fix trigger reference couting
authorLars-Peter Clausen <lars@metafoo.de>
Sun, 24 Oct 2021 09:26:59 +0000 (11:26 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Dec 2021 09:04:49 +0000 (10:04 +0100)
commitfb75cc4740d81264cd5bcb0e17d961d018a8be96
treefcbe823a54b0acb62eec30e54306fe9243727f72
parent3bcb9b058f1dbfcd9e4678ffdcb88c60e2e82f3c
iio: mma8452: Fix trigger reference couting

commit cd0082235783f814241a1c9483fb89e405f4f892 upstream.

The mma8452 driver directly assigns a trigger to the struct iio_dev. The
IIO core when done using this trigger will call `iio_trigger_put()` to drop
the reference count by 1.

Without the matching `iio_trigger_get()` in the driver the reference count
can reach 0 too early, the trigger gets freed while still in use and a
use-after-free occurs.

Fix this by getting a reference to the trigger before assigning it to the
IIO device.

Fixes: ae6d9ce05691 ("iio: mma8452: Add support for interrupt driven triggers.")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20211024092700.6844-1-lars@metafoo.de
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/accel/mma8452.c