]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
dm: clear cloned request bio pointer when last clone bio completes
authorMichael Liang <mliang@purestorage.com>
Fri, 9 Jan 2026 22:52:54 +0000 (15:52 -0700)
committerMikulas Patocka <mpatocka@redhat.com>
Wed, 14 Jan 2026 12:23:54 +0000 (13:23 +0100)
commitfb8a6c18fb9a6561f7a15b58b272442b77a242dd
treebb3537ed3108e58d34b282a6e696fd2d1397d916
parentc84e21a89b77731d69d27c74e92f99b39a5a54ef
dm: clear cloned request bio pointer when last clone bio completes

Stale rq->bio values have been observed to cause double-initialization of
cloned bios in request-based device-mapper targets, leading to
use-after-free and double-free scenarios.

One such case occurs when using dm-multipath on top of a PCIe NVMe
namespace, where cloned request bios are freed during
blk_complete_request(), but rq->bio is left intact. Subsequent clone
teardown then attempts to free the same bios again via
blk_rq_unprep_clone().

The resulting double-free path looks like:

  nvme_pci_complete_batch()
    nvme_complete_batch()
      blk_mq_end_request_batch()
        blk_complete_request()        // called on a DM clone request
          bio_endio()                 // first free of all clone bios
          ...
        rq->end_io()                  // end_clone_request()
          dm_complete_request(tio->orig)
            dm_softirq_done()
              dm_done()
                dm_end_request()
                  blk_rq_unprep_clone()  // second free of clone bios

Fix this by clearing the clone request's bio pointer when the last cloned
bio completes, ensuring that later teardown paths do not attempt to free
already-released bios.

Signed-off-by: Michael Liang <mliang@purestorage.com>
Reviewed-by: Mohamed Khalfella <mkhalfella@purestorage.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
drivers/md/dm-rq.c