]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iommu/amd: Fix incorrect error handling in amd_iommu_bind_pasid()
authorPan Bian <bianpan2016@163.com>
Sun, 23 Apr 2017 10:23:21 +0000 (18:23 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Jul 2017 12:35:15 +0000 (14:35 +0200)
commitfbb7b439df6d8b58ebeee8983add85abd28fbfcf
treeff887c4a91cc410cfadad71f75ae235e1e0ca031
parentcfeac3d9137d31716848a4af51ea463831c2fc4a
iommu/amd: Fix incorrect error handling in amd_iommu_bind_pasid()

commit 73dbd4a4230216b6a5540a362edceae0c9b4876b upstream.

In function amd_iommu_bind_pasid(), the control flow jumps
to label out_free when pasid_state->mm and mm is NULL. And
mmput(mm) is called.  In function mmput(mm), mm is
referenced without validation. This will result in a NULL
dereference bug. This patch fixes the bug.

Signed-off-by: Pan Bian <bianpan2016@163.com>
Fixes: f0aac63b873b ('iommu/amd: Don't hold a reference to mm_struct')
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iommu/amd_iommu_v2.c