]> git.ipfire.org Git - thirdparty/libvirt.git/commit
storage: Don't remove the pool for buildPool failure in storagePoolCreate
authorJohn Ferlan <jferlan@redhat.com>
Thu, 4 Aug 2016 19:24:48 +0000 (15:24 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Fri, 5 Aug 2016 13:30:54 +0000 (09:30 -0400)
commitfbfd6f2103a56df73238b023032dfb1242a4d7d5
treee5005a078a75fd34d9f502d6ef00ec55b4988eed
parent3f19ac3486c7d59d1892ba98f1bbb972b456359d
storage: Don't remove the pool for buildPool failure in storagePoolCreate

https://bugzilla.redhat.com/show_bug.cgi?id=1362349

When adding the ability to build the pool during the start pool processing
using the similar flags as buildPool processing would use, the code was
essentially cut-n-pasted from storagePoolCreateXML.  However, that included
a call to virStoragePoolObjRemove which shouldn't happen within the
storagePoolCreate path since that'll remove the pool from the list of
pools only to be rediscovered if libvirtd restarts.

So on failure, just fail and return as we should expect
src/storage/storage_driver.c