]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
rapidio/tsi721: prevent a bad dereference in tsi721_db_dpc()
authorDan Carpenter <error27@gmail.com>
Fri, 8 May 2026 07:51:56 +0000 (10:51 +0300)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 29 May 2026 04:24:45 +0000 (21:24 -0700)
commitfc15e3a30ddd950f009c76765331783b9af94a87
treec98353ff8da36ccf692ee48edf3b4493f66d05b6
parent5a13e296a3e32a70db2a520d8611a53d7bde10e8
rapidio/tsi721: prevent a bad dereference in tsi721_db_dpc()

With a list_for_each() loop, if we don't find the item we are looking for
in the list, then the loop exits with the iterator, which is "dbell" in
this loop, pointing to invalid memory.

This code uses the "found" variable to determine if we have found the
doorbell we are looking for or not.  However, the problem that the "found"
variable needs to be set to false at the start of each iteration,
otherwise after the first correct doorbell, then everything is marked as
found.

Reset the "found" to false at the start of the iteration and move the
variable inside the loop.

Link: https://lore.kernel.org/af2WHMZiqMwdYveO@stanley.mountain
Fixes: 48618fb4e522 ("RapidIO: add mport driver for Tsi721 bridge")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: Alexandre Bounine <alex.bou9@gmail.com>
Cc: Chul Kim <chul.kim@idt.com>
Cc: Matt Porter <mporter@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/rapidio/devices/tsi721.c