]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Validate memory hotplug in domainValidateCallback instead of cmd line generator
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 28 Jul 2020 08:51:32 +0000 (10:51 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 1 Sep 2020 07:30:27 +0000 (09:30 +0200)
commitfc19155819a50c20df45dcbe8d8d0e591cd07730
tree7a6744c944f69286c0b6b95005c7fc8a98dde55a
parent50410baa83e2094132aae5220540f8ff5a123846
qemu: Validate memory hotplug in domainValidateCallback instead of cmd line generator

When editing a domain with hotplug enabled, I removed the only
NUMA node it had and got no error. I got the error later though,
when starting the domain. This is not as user friendly as it can
be. Move the validation call out from command line generator and
into domain validator (which is called prior to starting cmd line
generation anyway).

When doing this, I had to remove memory-hotplug-nonuma xml2xml
test case because there is no way the test case can succeed,
obviously.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
src/qemu/qemu_command.c
src/qemu/qemu_domain.c
src/qemu/qemu_validate.c
tests/qemuxml2argvtest.c
tests/qemuxml2xmloutdata/memory-hotplug-nonuma.xml [deleted file]
tests/qemuxml2xmltest.c