]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: seq: oss: Fix unbalanced use lock for synth MIDI device
authorTakashi Iwai <tiwai@suse.de>
Tue, 24 Apr 2018 05:26:59 +0000 (07:26 +0200)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:36:38 +0000 (21:36 -0400)
commitfc2fc4694a85effc0fc920997241f20c0775eb9e
treecaea5b2761e95ee6cb39243d8e18d96a6ce394a6
parent13cc4cf41d6bd031b714b7fa5561d937533ff526
ALSA: seq: oss: Fix unbalanced use lock for synth MIDI device

[ Upstream commit f5e94b4c6ebdabe0f602d796e0430180927521a0 ]

When get_synthdev() is called for a MIDI device, it returns the fixed
midi_synth_dev without the use refcounting.  OTOH, the caller is
supposed to unreference unconditionally after the usage, so this would
lead to unbalanced refcount.

This patch corrects the behavior and keep up the refcount balance also
for the MIDI synth device.

Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
sound/core/seq/oss/seq_oss_synth.c