]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mmc: wbsd: fix return value check of mmc_add_host()
authorYang Yingliang <yangyingliang@huawei.com>
Wed, 9 Nov 2022 13:32:37 +0000 (21:32 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 7 Jan 2023 11:07:20 +0000 (12:07 +0100)
commitfc85606bdfc246ccbeca41f9067ff5f8267a2d97
tree62cdb67964fe0f7131490262e1554d743f75e530
parent076bcd2c93e16b05c10564e299d6e5d26a766d00
mmc: wbsd: fix return value check of mmc_add_host()

[ Upstream commit dc5b9b50fc9d1334407e316e6e29a5097ef833bd ]

mmc_add_host() may return error, if we ignore its return value,
it will lead two issues:
1. The memory that allocated in mmc_alloc_host() is leaked.
2. In the remove() path, mmc_remove_host() will be called to
   delete device, but it's not added yet, it will lead a kernel
   crash because of null-ptr-deref in device_del().

So fix this by checking the return value and goto error path which
will call mmc_free_host(), besides, other resources also need be
released.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221109133237.3273558-1-yangyingliang@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mmc/host/wbsd.c