]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iio: accel: mma9551_core: Prevent uninitialized variable in mma9551_read_status_word()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Thu, 26 Jan 2023 15:21:46 +0000 (07:21 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 15:32:01 +0000 (16:32 +0100)
commitfcd058534ae439bc685f791232efae94d4b02dc1
treedd3f736600e1c921a120e5fe748a74682449c03b
parent443e4d7788b33b3c544aca0748d65bf824241640
iio: accel: mma9551_core: Prevent uninitialized variable in mma9551_read_status_word()

[ Upstream commit e56d2c34ce9dc122b1a618172ec0e05e50adb9e9 ]

Smatch Warns: drivers/iio/accel/mma9551_core.c:357
mma9551_read_status_word() error: uninitialized symbol 'v'.

When (offset >= 1 << 12) is true mma9551_transfer() will return -EINVAL
without 'v' being initialized, so check for the error and return.

Note: Not a bug as such because the caller checks return value and
doesn't not use this parameter in the problem case.

Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20230126152147.3585874-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/accel/mma9551_core.c