]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
propagate_one(): mnt_set_mountpoint() needs mount_lock
authorAl Viro <viro@zeniv.linux.org.uk>
Mon, 27 Apr 2020 14:26:22 +0000 (10:26 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 2 May 2020 15:23:20 +0000 (17:23 +0200)
commitfcd41818e1cd2085e2ef6fe413af5657658415d5
tree0f47838a2607cecf9221a8cc99bde8c0f680e9bf
parentb1880905a1cf0ab136122e9dbae532cde5e4d58e
propagate_one(): mnt_set_mountpoint() needs mount_lock

commit b0d3869ce9eeacbb1bbd541909beeef4126426d5 upstream.

... to protect the modification of mp->m_count done by it.  Most of
the places that modify that thing also have namespace_lock held,
but not all of them can do so, so we really need mount_lock here.
Kudos to Piotr Krysiuk <piotras@gmail.com>, who'd spotted a related
bug in pivot_root(2) (fixed unnoticed in 5.3); search for other
similar turds has caught out this one.

Cc: stable@kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Piotr Krysiuk <piotras@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/pnode.c