]> git.ipfire.org Git - thirdparty/libvirt.git/commit
util: simplify virCommand APIs for env passthrough.
authorDaniel P. Berrangé <berrange@redhat.com>
Thu, 1 Aug 2019 12:52:00 +0000 (13:52 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Wed, 7 Aug 2019 15:54:02 +0000 (16:54 +0100)
commitfcf93c3ee0ed24d282da37713f4e8be0ce79a7c7
tree44c06c8552c3d6a1ebf932afdc717dd45ba7cd0f
parent0c691684863a94219c63d23e8caeb7e79742a385
util: simplify virCommand APIs for env passthrough.

Now that 100% of libvirt code is forbidden in a SUID environment,
we no longer need to worry about whether env variables are
trustworthy or not. The virt-login-shell setuid program, which
does not link to any libvirt code, will purge all environment
variables, except $TERM, before invoking the virt-login-shell-helper
program which uses libvirt.

Thus we only need one API for env passthrough in virCommand.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/libvirt_private.syms
src/lxc/lxc_process.c
src/qemu/qemu_command.c
src/rpc/virnetsocket.c
src/util/vircommand.c
src/util/vircommand.h
tests/commandtest.c