]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: smiapp: Only some selection targets are settable
authorSakari Ailus <sakari.ailus@iki.fi>
Thu, 6 Nov 2014 20:49:45 +0000 (17:49 -0300)
committerJiri Slaby <jslaby@suse.cz>
Wed, 7 Jan 2015 15:20:13 +0000 (16:20 +0100)
commitfd120bec1cfd1e12f996081c367a6600832fa811
tree463fc3139b57a48d0ad717a1595345c361beea4f
parentaa4e539e52e4a364cc599b69240c473fd6e9f445
media: smiapp: Only some selection targets are settable

commit b31eb901c4e5eeef4c83c43dfbc7fe0d4348cb21 upstream.

Setting a non-settable selection target caused BUG() to be called. The check
for valid selections only takes the selection target into account, but does
not tell whether it may be set, or only get. Fix the issue by simply
returning an error to the user.

Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/media/i2c/smiapp/smiapp-core.c