]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
lib/xz: Validate the value before assigning it to an enum variable
authorLasse Collin <lasse.collin@tukaani.org>
Sun, 10 Oct 2021 21:31:40 +0000 (05:31 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Nov 2021 10:36:06 +0000 (11:36 +0100)
commitfd6979aff272ff28db52b7dae648ecd151d9d553
tree901cf2c27d550a6b9a1a5134a556c3947059a157
parent543d8854c4bf2f77b1ede6a0c319a5b5c4fd8c4e
lib/xz: Validate the value before assigning it to an enum variable

[ Upstream commit 4f8d7abaa413c34da9d751289849dbfb7c977d05 ]

This might matter, for example, if the underlying type of enum xz_check
was a signed char. In such a case the validation wouldn't have caught an
unsupported header. I don't know if this problem can occur in the kernel
on any arch but it's still good to fix it because some people might copy
the XZ code to their own projects from Linux instead of the upstream
XZ Embedded repository.

This change may increase the code size by a few bytes. An alternative
would have been to use an unsigned int instead of enum xz_check but
using an enumeration looks cleaner.

Link: https://lore.kernel.org/r/20211010213145.17462-3-xiang@kernel.org
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
lib/xz/xz_dec_stream.c