]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pg_dump: tests: Correct test condition for invalid databases
authorAndres Freund <andres@anarazel.de>
Mon, 25 Sep 2023 18:50:02 +0000 (11:50 -0700)
committerAndres Freund <andres@anarazel.de>
Mon, 25 Sep 2023 19:10:46 +0000 (12:10 -0700)
commitfd7a114dbb4e8b700b0b738bb9c513b5fa3198a3
tree79aa2bf122b1f972646260584b8a1c52b2350092
parent4435a8d5dbabbe41fc1c4b7b8dff34902853a07b
pg_dump: tests: Correct test condition for invalid databases

For some reason I used not_like = { pg_dumpall_dbprivs => 1, } in the test
condition of one of the tests added in in c66a7d75e65. That doesn't make sense
for two reasons: 1) not_like isn't a valid test condition 2) the database
should not be dumped in any of the tests.  Due to 1), the test achieved its
goal, but clearly the formulation is confusing.  Instead use like => {}, with
a comment explaining why.

Reported-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://postgr.es/m/3ddf79f2-8b7b-a093-11d2-5c739bc64f86@eisentraut.org
Backpatch: 11-, like c66a7d75e65
src/bin/pg_dump/t/002_pg_dump.pl