]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Remove entry tree root conflict checking from GIN predicate locking
authorAlexander Korotkov <akorotkov@postgresql.org>
Thu, 27 Dec 2018 01:10:51 +0000 (04:10 +0300)
committerAlexander Korotkov <akorotkov@postgresql.org>
Thu, 27 Dec 2018 01:20:21 +0000 (04:20 +0300)
commitfd7c081955929df343318d6c5d32ea24a574aacf
tree5cefc66e3b61f574051583b2fbe01d8f3ef38e19
parentb30b9dce1f40499949fd3749265acf1b379102dc
Remove entry tree root conflict checking from GIN predicate locking

According to README we acquire predicate locks on entry tree leafs and posting
tree roots.  However, when ginFindLeafPage() is going to lock leaf in exclusive
mode, then it checks root for conflicts regardless whether it's a entry or
posting tree.  Assuming that we never place predicate lock on entry tree root
(excluding corner case when root is leaf), this check is redundant.  This
commit removes this check.  Now, root conflict checking is controlled by
separate argument of ginFindLeafPage().

Discussion: https://postgr.es/m/CAPpHfdv7rrDyy%3DMgsaK-L9kk0AH7az0B-mdC3w3p0FSb9uoyEg%40mail.gmail.com
Author: Alexander Korotkov
Backpatch-through: 11
src/backend/access/gin/ginbtree.c
src/backend/access/gin/gindatapage.c
src/backend/access/gin/ginget.c
src/backend/access/gin/gininsert.c
src/include/access/gin_private.h