]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: fsl_micfil: Enable default case in micfil_set_quality()
authorNikita Zhandarovich <n.zhandarovich@fintech.ru>
Thu, 16 Jan 2025 14:24:36 +0000 (06:24 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Mar 2025 15:56:39 +0000 (16:56 +0100)
commitfde718a5855855975e74248502cd3f9ef488fa6a
tree8ef758978aeef693533ca8af72a42b9d960b8567
parent1358d8e07afdf21d49ca6f00c56048442977e00a
ASoC: fsl_micfil: Enable default case in micfil_set_quality()

commit a8c9a453387640dbe45761970f41301a6985e7fa upstream.

If 'micfil->quality' received from micfil_quality_set() somehow ends
up with an unpredictable value, switch() operator will fail to
initialize local variable qsel before regmap_update_bits() tries
to utilize it.

While it is unlikely, play it safe and enable a default case that
returns -EINVAL error.

Found by Linux Verification Center (linuxtesting.org) with static
analysis tool SVACE.

Fixes: bea1d61d5892 ("ASoC: fsl_micfil: rework quality setting")
Cc: stable@vger.kernel.org
Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
Link: https://patch.msgid.link/20250116142436.22389-1-n.zhandarovich@fintech.ru
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/fsl/fsl_micfil.c