]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: don't touch dev->stats in BPF redirect paths
authorJakub Kicinski <kuba@kernel.org>
Fri, 30 Jan 2026 03:38:27 +0000 (19:38 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 31 Jan 2026 20:35:27 +0000 (12:35 -0800)
commitfdf3f6800be36377e045e2448087f12132b88d2f
tree820b5ab869b1c58ad0408e2de3102b3e49a6b80b
parent6d06bc83a5ae8777a5f7a81c32dd75b8d9b2fe04
net: don't touch dev->stats in BPF redirect paths

Gal reports that BPF redirect increments dev->stats.tx_errors
on failure. This is not correct, most modern drivers completely
ignore dev->stats so these drops will be invisible to the user.
Core code should use the dedicated core stats which are folded
into device stats in dev_get_stats().

Note that we're switching from tx_errors to tx_dropped.
Core only has tx_dropped, hence presumably users already expect
that counter to increment for "stack" Tx issues.

Reported-by: Gal Pressman <gal@nvidia.com>
Link: https://lore.kernel.org/c5df3b60-246a-4030-9c9a-0a35cd1ca924@nvidia.com
Fixes: b4ab31414970 ("bpf: Add redirect_neigh helper as redirect drop-in")
Acked-by: Martin KaFai Lau <martin.lau@kernel.org>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20260130033827.698841-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/filter.c