]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bfq: Drop pointless unlock-lock pair
authorJan Kara <jack@suse.cz>
Fri, 1 Apr 2022 10:27:46 +0000 (12:27 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:26:18 +0000 (10:26 +0200)
commitfe48ab034453fbe1f8bec496b7f5c1fb5201e24b
tree2c386da80dd571fc13bcc8397c1fb7e5f875929d
parentd9165200c5627a2cf4408eefabdf0058bdf95e1a
bfq: Drop pointless unlock-lock pair

commit fc84e1f941b91221092da5b3102ec82da24c5673 upstream.

In bfq_insert_request() we unlock bfqd->lock only to call
trace_block_rq_insert() and then lock bfqd->lock again. This is really
pointless since tracing is disabled if we really care about performance
and even if the tracepoint is enabled, it is a quick call.

CC: stable@vger.kernel.org
Tested-by: "yukuai (C)" <yukuai3@huawei.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20220401102752.8599-5-jack@suse.cz
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
block/bfq-iosched.c