]> git.ipfire.org Git - thirdparty/linux.git/commit
firmware_loader: Only call cancel when upload is active
authorKaushlendra Kumar <kaushlendra.kumar@intel.com>
Thu, 25 Sep 2025 05:41:29 +0000 (11:11 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Oct 2025 06:09:23 +0000 (08:09 +0200)
commitfe6193a3187a1a7482ccfbc904bc527e7730a36c
tree8bd3b257b0c5877f2ea2bd99e7661207f0ca539a
parent0242623384c767b1156b61b67894b4ecf6682b8b
firmware_loader: Only call cancel when upload is active

The cancel_store() function currently calls the firmware upload cancel
operation even when no upload is in progress (i.e., when progress is
FW_UPLOAD_PROG_IDLE).

Update cancel_store() to only invoke the cancel operation when an upload
is active. If the upload is idle, return -ENODEV without calling cancel.

This change improves safety and correctness by ensuring driver operations
are only called in valid states.

Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Link: https://patch.msgid.link/20250925054129.2199157-1-kaushlendra.kumar@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/firmware_loader/sysfs_upload.c