]> git.ipfire.org Git - thirdparty/snort3.git/commit
Pull request #4547: stream_tcp: refactor tcp normalizer initialization to eliminate...
authorDavis McPherson -X (davmcphe - XORIANT CORPORATION at Cisco) <davmcphe@cisco.com>
Tue, 18 Mar 2025 15:00:38 +0000 (15:00 +0000)
committerSteven Baigal (sbaigal) <sbaigal@cisco.com>
Tue, 18 Mar 2025 15:00:38 +0000 (15:00 +0000)
commitfe69df9233bc62c38cac7495c186fdbd9cd60481
treea26841f31cf20d87d0306d5afb0072980f4ff6c7
parentf7b5c5283c1b8c2a3d2601b5129ffa05f4caa9f0
Pull request #4547: stream_tcp: refactor tcp normalizer initialization to eliminate duplicate initializations

Merge in SNORT/snort3 from ~DAVMCPHE/snort3:stream_tcp_norm_init to master

Squashed commit of the following:

commit e8a5e275d89b22f5eb9d3b688a2b84650cb5e209
Author: davis mcpherson <davmcphe@cisco.com>
Date:   Tue Sep 24 15:57:10 2024 -0400

    imap:pop: delete if expression that compared session flag to the packet_flag filed

commit 395f937f5ec39f22e735cdc094fc34008c0ce359
Author: davis mcpherson <davmcphe@cisco.com>
Date:   Thu Jan 30 09:51:01 2025 -0500

    stream_tcp: make member variables private to improve tracker class encapsulation

commit 3934da1fee6f5f0c72bfa55cf2c5a02d9f651cc0
Author: davis mcpherson <davmcphe@cisco.com>
Date:   Thu Mar 13 10:41:54 2025 -0400

    stream_tcp: reduce verbosity of packet tracer log messages for normalizer initialization actions

    stream_tcp: split StreamPolicy enum into enums specific to normalization and to overlap resolution

commit a3e4777c89136f3de3bcc67d365626dca7563b51
Author: davis mcpherson <davmcphe@cisco.com>
Date:   Thu Sep 12 11:03:06 2024 -0400

    stream_tcp: eliminate redundant calls to initialize the normalizer policy

    stream_tcp: only allow legacy OS and FIRST normalizer policies to be configurable. Proxy and missed 3whs modes are determined dynamically per flow

    stream_tcp: initialize each tracker's normalizer for missed 3whs behavior invidually when the initial packet is processed by the tracker
26 files changed:
src/service_inspectors/imap/imap.cc
src/service_inspectors/pop/pop.cc
src/stream/stream.h
src/stream/tcp/tcp_defs.h
src/stream/tcp/tcp_module.cc
src/stream/tcp/tcp_normalizer.cc
src/stream/tcp/tcp_normalizer.h
src/stream/tcp/tcp_normalizers.cc
src/stream/tcp/tcp_normalizers.h
src/stream/tcp/tcp_overlap_resolver.cc
src/stream/tcp/tcp_overlap_resolver.h
src/stream/tcp/tcp_reassembly_segments.cc
src/stream/tcp/tcp_reassembly_segments.h
src/stream/tcp/tcp_segment_node.cc
src/stream/tcp/tcp_session.cc
src/stream/tcp/tcp_state_fin_wait1.cc
src/stream/tcp/tcp_state_listen.cc
src/stream/tcp/tcp_state_mid_stream_recv.cc
src/stream/tcp/tcp_state_mid_stream_sent.cc
src/stream/tcp/tcp_state_none.cc
src/stream/tcp/tcp_state_syn_recv.cc
src/stream/tcp/tcp_state_syn_sent.cc
src/stream/tcp/tcp_stream_config.h
src/stream/tcp/tcp_stream_tracker.cc
src/stream/tcp/tcp_stream_tracker.h
src/stream/tcp/test/tcp_normalizer_test.cc