]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-44630: Fix assertion errors in csv module (GH-27127)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Tue, 13 Jul 2021 23:20:28 +0000 (16:20 -0700)
committerGitHub <noreply@github.com>
Tue, 13 Jul 2021 23:20:28 +0000 (16:20 -0700)
commitfe73509c5ba3844b45a2253967522531ab80c849
tree796175ecfbd0d614b88f90b1390b1bc942e13079
parenta3d20bfee38c71df88d69064d47fe98a1d59e624
bpo-44630: Fix assertion errors in csv module (GH-27127)

Fix incorrect handling of exceptions when interpreting dialect objects in
the csv module. Not clearing exceptions between calls to
PyObject_GetAttrString() causes assertion failures in pydebug mode (or with
assertions enabled).

Add a minimal test that would've caught this (passing None as dialect, or
any object that isn't a csv.Dialect subclass, which the csv module allows
and caters to, even though it is not documented.) In pydebug mode, the test
triggers the assertion failure in the old code.

Contributed-By: T. Wouters [Google]
(cherry picked from commit 0093876328afa330224c9d887c18dee0b3117852)

Co-authored-by: T. Wouters <thomas@python.org>
Lib/test/test_csv.py
Modules/_csv.c