]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
atm: solos-pci: Fix potential deadlock on &tx_queue_lock
authorChengfeng Ye <dg573847474@gmail.com>
Thu, 7 Dec 2023 12:34:53 +0000 (12:34 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Dec 2023 14:17:35 +0000 (15:17 +0100)
commitfe779dbb42fb0c62bd0b950f46950dc7e39b5ff9
treed9ca4bcf19d040cda51b4ed30d51933005d3cb44
parente16f961f8bc5fe240f12afd8a4bc700002071157
atm: solos-pci: Fix potential deadlock on &tx_queue_lock

[ Upstream commit 15319a4e8ee4b098118591c6ccbd17237f841613 ]

As &card->tx_queue_lock is acquired under softirq context along the
following call chain from solos_bh(), other acquisition of the same
lock inside process context should disable at least bh to avoid double
lock.

<deadlock #2>
pclose()
--> spin_lock(&card->tx_queue_lock)
<interrupt>
   --> solos_bh()
   --> fpga_tx()
   --> spin_lock(&card->tx_queue_lock)

This flaw was found by an experimental static analysis tool I am
developing for irq-related deadlock.

To prevent the potential deadlock, the patch uses spin_lock_bh()
on &card->tx_queue_lock under process context code consistently to
prevent the possible deadlock scenario.

Fixes: 213e85d38912 ("solos-pci: clean up pclose() function")
Signed-off-by: Chengfeng Ye <dg573847474@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/atm/solos-pci.c