]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
HID: input: Fix TransducerSerialNumber implementation
authorJason Gerecke <killertofu@gmail.com>
Tue, 23 Sep 2014 18:09:28 +0000 (11:09 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Nov 2014 18:10:26 +0000 (10:10 -0800)
commitfedb1e978b3d017064e9591c185049538a5164ea
tree03b495905b07d140f41743a2267ad89653369055
parented9a984568179de2b1e77060170d29f51f15cd3f
HID: input: Fix TransducerSerialNumber implementation

commit 5989a55a4c9aafba8b152c6bf52244510c2b88b9 upstream.

The commit which introduced TransducerSerialNumber (368c966) is missing
two crucial implementation details. Firstly, the commit does not set the
type/code/bit/max fields as expected later down the code which can cause
the driver to crash when a tablet with this usage is connected. Secondly,
the call to 'set_bit' causes MSC_PULSELED to be sent instead of the
expected MSC_SERIAL. This commit addreses both issues.

Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Reviewed-by: Ping Cheng <pingc@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-input.c