]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
power: supply: axp288_charger: Fix constant_charge_voltage writes
authorHans de Goede <hdegoede@redhat.com>
Wed, 17 Jul 2024 20:03:32 +0000 (22:03 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Aug 2024 03:45:46 +0000 (05:45 +0200)
commitff03c1b9409ef4672d3f48f92264cea7a12377a9
treeff0970d52dc4966c2059038dcd8a8e2a8c5fec2c
parent0ad02834c2bfc67992b7ddb97a2ce03e6cc4b66e
power: supply: axp288_charger: Fix constant_charge_voltage writes

commit b34ce4a59cfe9cd0d6f870e6408e8ec88a964585 upstream.

info->max_cv is in millivolts, divide the microvolt value being written
to constant_charge_voltage by 1000 *before* clamping it to info->max_cv.

Before this fix the code always tried to set constant_charge_voltage
to max_cv / 1000 = 4 millivolt, which ends up in setting it to 4.1V
which is the lowest supported value.

Fixes: 843735b788a4 ("power: axp288_charger: axp288 charger driver")
Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20240717200333.56669-1-hdegoede@redhat.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/power/supply/axp288_charger.c