]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ksmbd: fix incorrect handling of iterate_dir
authorNamjae Jeon <linkinjeon@kernel.org>
Fri, 9 Sep 2022 08:43:53 +0000 (17:43 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2022 07:56:51 +0000 (09:56 +0200)
commitff5814fdced4c13557606ae78998db5e591a9142
tree4c56a635740d215718d4a07c6fdd893cbd0a9d62
parentd2c9555cce37984c94a65b6386c992ed40632a68
ksmbd: fix incorrect handling of iterate_dir

commit 88541cb414b7a2450c45fc9c131b37b5753b7679 upstream.

if iterate_dir() returns non-negative value, caller has to treat it
as normal and check there is any error while populating dentry
information. ksmbd doesn't have to do anything because ksmbd already
checks too small OutputBufferLength to store one file information.

And because ctx->pos is set to file->f_pos when iterative_dir is called,
remove restart_ctx(). And if iterate_dir() return -EIO, which mean
directory entry is corrupted, return STATUS_FILE_CORRUPT_ERROR error
response.

This patch fixes some failure of SMB2_QUERY_DIRECTORY, which happens when
ntfs3 is local filesystem.

Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
Cc: stable@vger.kernel.org
Signed-off-by: Hyunchul Lee <hyc.lee@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ksmbd/smb2pdu.c