]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: command: Fix building of the SDL display command line
authorErik Skultety <eskultet@redhat.com>
Tue, 19 Jun 2018 16:04:57 +0000 (18:04 +0200)
committerErik Skultety <eskultet@redhat.com>
Mon, 9 Jul 2018 15:45:19 +0000 (17:45 +0200)
commitff767f083f559ee1143b7347169ffdeb51de65e7
treedf4976891723d2b334827235223d109e9436df1d
parent8ec7c8ce7634aa169d881097c0e4863cfc6b5ec0
qemu: command: Fix building of the SDL display command line

QEMU uses a shorthand '-sdl' which maps to '-display sdl'. However, if
there are any options to be passed to SDL, the full command version must
be used. Everything seemingly worked for us until commit 5038b300437
introduced OpenGL support for SDL and added ',gl=on/off' option which as
mentioned above could have never worked with the shorthand version of
the command. Indeed starting a domain with an SDL display and OpenGL
enabled, QEMU produces a rather cryptic error:

-sdl: Could not open 'gl=on': No such file or directory

This patch provides fixes to both the SDL cmdline generation and the
test suite.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
src/qemu/qemu_command.c
tests/qemuxml2argvdata/graphics-sdl-fullscreen.args
tests/qemuxml2argvdata/graphics-sdl.args
tests/qemuxml2argvdata/video-virtio-gpu-sdl-gl.args