]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: remove use of qemuDomainObjBeginJobWithAgent()
authorJonathon Jongsma <jjongsma@redhat.com>
Thu, 5 Dec 2019 16:08:56 +0000 (10:08 -0600)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 12 Dec 2019 14:43:58 +0000 (15:43 +0100)
commitffa5066a49686e61991759983b0d7d1ba707fe50
tree4dd0b5977e10919403b0cc589e5f257b3eb6b353
parente005c95f56fee9ed780be7f8db103d690bd34cbd
qemu: remove use of qemuDomainObjBeginJobWithAgent()

This function will be removed in a future commit because it allows the
caller to acquire both monitor and agent jobs at the same time. Holding
both job types creates a vulnerability to denial of service from a
malicious guest agent.

qemuDomainSetVcpusFlags() always passes NONE for either the monitor job
or the agent job (and thus is not vulnerable to the DoS), so we can
simply replace this function with the functions for acquiring the
appropriate type of job.

Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_driver.c