]> git.ipfire.org Git - thirdparty/asterisk.git/commit
app_dial: Hold reference to calling channel formats when dialing outbound. 02/702/2
authorJoshua Colp <jcolp@digium.com>
Tue, 23 Jun 2015 16:21:41 +0000 (13:21 -0300)
committerJoshua Colp <jcolp@digium.com>
Wed, 24 Jun 2015 18:50:55 +0000 (13:50 -0500)
commite99e654d75a2428ce4b8bc504acf2ec1927779ed
tree4d4374dbf4d75e0609cdf621b21814e4837c9d2e
parenta419c69def639745ac9988b3800501f68dfef350
app_dial: Hold reference to calling channel formats when dialing outbound.

Currently when requesting a channel the native formats of the
calling channel are provided to the core for usage when dialing
the outbound channel. This occurs without holding the channel lock
or keeping a reference to the formats. This is problematic as
the channel driver may end up changing the formats during this time.
In the case of chan_sip this happens when an SDP negotiation
completes.

This change makes it so app_dial keeps a reference to the native
formats of the calling channel which guarantees that they will
remain valid for the period of time needed.

ASTERISK-25172 #close

Change-Id: I2f0a67bd0d5d14c3bdbaae552b4b1613a283f0db
apps/app_dial.c