]> git.ipfire.org Git - thirdparty/asterisk.git/commit
res_pjsip: Copy default_from_user to avoid crash. 37/1237/1
authorMark Michelson <mmichelson@digium.com>
Thu, 10 Sep 2015 14:49:45 +0000 (09:49 -0500)
committerMark Michelson <mmichelson@digium.com>
Thu, 10 Sep 2015 14:55:08 +0000 (09:55 -0500)
commit8826e6c416ce1b97b4e85e06913df65cb84dade5
tree813196fa305509d2667ef6e8372809089042adea
parent943d5c0c996d92e187c4576a5919819d2c62a79a
res_pjsip: Copy default_from_user to avoid crash.

The default_from_user retrieval function was pulling the
default_from_user from the global configuration struct in an unsafe way.
If using a database as a backend configuration store, the global
configuration struct is short-lived, so grabbing a pointer from it
results in referencing freed memory.

The fix here is to copy the default_from_user value out of the global
configuration struct.

Thanks go to John Hardin for discovering this problem and proposing the
patch on which this fix is based.

ASTERISK-25390 #close
Reported by Mark Michelson

Change-Id: I6b96067a495c1259da768f4012d44e03e7c6148c
include/asterisk/res_pjsip.h
res/res_pjsip.c
res/res_pjsip/config_global.c