]> git.ipfire.org Git - thirdparty/asterisk.git/commit
pjsip: Fix a few media bugs with reinvites and asymmetric payloads. 72/4172/3
authorJoshua Colp <jcolp@digium.com>
Sun, 23 Oct 2016 12:38:59 +0000 (12:38 +0000)
committerJoshua Colp <jcolp@digium.com>
Wed, 26 Oct 2016 12:47:59 +0000 (12:47 +0000)
commite0bc17edfff27bb9dbbe931814fb5653005f3219
tree8b84db5cb09cd1469a7be469436bec66d26b3e64
parent2bd8af6d0bc3cc9e08457924f190a76ff8cbb0b7
pjsip: Fix a few media bugs with reinvites and asymmetric payloads.

When channel format changes occurred as a result of an RTP
re-negotiation the bridge was not informed this had happened.
As a result the bridge technology was not re-evaluated and the
channel may have been in a bridge technology that was incompatible
with its formats. The bridge is now unbridged and the technology
re-evaluated when this occurs.

The chan_pjsip module also allowed asymmetric codecs for sending
and receiving. This did not work with all devices and caused one
way audio problems. The default has been changed to NOT do this
but to match the sending codec to the receiving codec. For users
who want asymmetric codecs an option has been added, asymmetric_rtp_codec,
which will return chan_pjsip to the previous behavior.

The codecs returned by the chan_pjsip module when queried by
the bridge_native_rtp module were also not reflective of the
actual negotiated codecs. The nativeformats are now returned as
they reflect the actual negotiated codecs.

ASTERISK-26423 #close

Change-Id: I6ec88c6e3912f52c334f1a26983ccb8f267020dc
CHANGES
channels/chan_pjsip.c
configs/samples/pjsip.conf.sample
contrib/ast-db-manage/config/versions/4468b4a91372_add_pjsip_asymmetric_rtp_codec.py [new file with mode: 0644]
include/asterisk/res_pjsip.h
res/res_pjsip.c
res/res_pjsip/pjsip_configuration.c
res/res_pjsip_sdp_rtp.c