]> git.ipfire.org Git - thirdparty/asterisk.git/commit
chan_sip.c: Fix session timers deadlock potential. 95/2395/3
authorRichard Mudgett <rmudgett@digium.com>
Tue, 8 Mar 2016 21:08:19 +0000 (15:08 -0600)
committerRichard Mudgett <rmudgett@digium.com>
Wed, 16 Mar 2016 19:53:00 +0000 (14:53 -0500)
commit98d5669c280dbf5ffcd8a0431aa44e7f465fcefe
tree4e30ac215eefb239b1bad83f0a843e3c10e7243a
parent9cb8f73226126db70bac54fd7af8093ab05ffd6f
chan_sip.c: Fix session timers deadlock potential.

This patch is part of a series to resolve deadlocks in chan_sip.c.

Stopping a scheduled event can result in a deadlock if the scheduled event
is running when you try to stop the event.  If you hold a lock needed by
the scheduled event while trying to stop the scheduled event then a
deadlock can happen.  The general strategy for resolving the deadlock
potential is to push the actual starting and stopping of the scheduled
events off onto the scheduler/do_monitor() thread by scheduling an
immediate one shot scheduled event.  Some restructuring may be needed
because the code may assume that the start/stop of the scheduled events is
immediate.

ASTERISK-25023

Change-Id: I6d65269151ba95e0d8fe4e9e611881cde2ab4900
channels/chan_sip.c
channels/sip/include/sip.h