]> git.ipfire.org Git - thirdparty/asterisk.git/commit
res_pjsip_outbound_publish: Ensure publish is valid when explicitly destroying. 98/2898/1
authorJoshua Colp <jcolp@digium.com>
Tue, 24 May 2016 10:28:17 +0000 (07:28 -0300)
committerJoshua Colp <jcolp@digium.com>
Tue, 24 May 2016 14:08:37 +0000 (11:08 -0300)
commit070eab6ed26b1bc287618f0372b8b4489f7479f3
tree20e657dfc08604c2edb18e54c1ea4fb19c1c7564
parent56d5af45847f598becfcfae57e96705cff4459ab
res_pjsip_outbound_publish: Ensure publish is valid when explicitly destroying.

Recent changes to res_pjsip_outbound_publish have introduced a
race condition at shutdown where an outbound publish may be shutdown
twice. In this case the first succeeds as a result of the unpublish.
In the second invocation since it's been unpublished a task is
queued to just destroy the client. This task holds no ref to the
publish and as a result the publish may be destroyed before the
task is run, causing a crash.

This explicit destruction task now holds a reference to the publish
to ensure it remains valid.

ASTERISK-26053 #close

Change-Id: I10789b98add3e50292ee3b33a55a1d9061cec94b
res/res_pjsip_outbound_publish.c