]> git.ipfire.org Git - thirdparty/libvirt.git/commit
network: avoid trying to create global firewall rules if unprivileged v5.1.0-maint
authorDaniel P. Berrangé <berrange@redhat.com>
Wed, 13 Mar 2019 16:21:15 +0000 (16:21 +0000)
committerDaniel P. Berrangé <berrange@redhat.com>
Wed, 20 Mar 2019 17:10:44 +0000 (17:10 +0000)
commit3e02ee9b5da7fc7197aaa6d57563349a7670b8a1
tree70d71ab5c133b2d2880074ad531a0a1a9fc7a063
parent095c45036615a84c7150ea801d6932bdde1d5b49
network: avoid trying to create global firewall rules if unprivileged

The unprivileged libvirtd does not have permission to create firewall
rules, or bridge devices, or do anything to the host network in
general. Historically we still activate the network driver though and
let the network start API call fail.

The startup code path which reloads firewall rules on active networks
would thus effectively be a no-op when unprivileged as it is impossible
for there to be any active networks

With the change to use a global set of firewall chains, however, we now
have code that is run unconditionally.

Ideally we would not register the network driver at all when
unprivileged, but the entanglement with the virt drivers currently makes
that impractical. As a temporary hack, we just make the firewall reload
into a no-op.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
(cherry picked from commit 5d010c3df6152cf5fb00f1f67d22151241f4a8a2)
src/network/bridge_driver.c