]> git.ipfire.org Git - thirdparty/pdns.git/commit
dnsdist: Fix the handling of DoH queries with a non-zero ID 10208/head
authorRemi Gacogne <remi.gacogne@powerdns.com>
Tue, 23 Mar 2021 14:22:09 +0000 (15:22 +0100)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Tue, 23 Mar 2021 14:22:09 +0000 (15:22 +0100)
commit80a6365917392df23a66e5853f650580c492b802
tree22859b04ac1286c567ee0e40cf646feafadb28c4
parente33b1b65a609dfb01c5360bfbca90e6d59e91476
dnsdist: Fix the handling of DoH queries with a non-zero ID

rfc8484 states that clients "SHOULD use a DNS ID of 0 in every DNS
request", not MUST, so it does indeed happen.
The issue was introduced in 341d2553b74c579df9d9843959f3ca6f5c3dc954
when we moved to a safer PacketBuffer.
pdns/dnsdistdist/doh.cc
regression-tests.dnsdist/test_DOH.py