]> git.ipfire.org Git - thirdparty/suricata.git/commit
util/interval-tree: fix coverity warning 10600/head
authorShivani Bhardwaj <shivani@oisf.net>
Fri, 8 Mar 2024 08:36:31 +0000 (14:06 +0530)
committerVictor Julien <victor@inliniac.net>
Fri, 8 Mar 2024 21:01:30 +0000 (22:01 +0100)
commit2d6708f1ff1e57f83f2dd9994173e8ee62e00616
tree3be41d9a1aedca69437796e02c790518c5827ce2
parentaf529a56a9bcb37bae5243236a4505fff0df268b
util/interval-tree: fix coverity warning

Fix Coverity warning

** CID 1592992:  Incorrect expression  (COPY_PASTE_ERROR)
/src/util-port-interval-tree.c: 255 in SCPortIntervalFindOverlaps()

________________________________________________________________________________________________________
*** CID 1592992:  Incorrect expression  (COPY_PASTE_ERROR)
/src/util-port-interval-tree.c: 255 in SCPortIntervalFindOverlaps()
249                      * will be sorted, insert any new ports to the end of the list
250                      * and avoid walking the entire list */
251                     if (*list == NULL) {
252                         *list = new_port;
253                         (*list)->last = new_port;
254                     } else if (((*list)->last->port != new_port->port) &&
>>>     CID 1592992:  Incorrect expression  (COPY_PASTE_ERROR)
>>>     "port" in "(*list)->last->port2 != new_port->port" looks like a copy-paste error.
255                                ((*list)->last->port2 != new_port->port)) {
256                         DEBUG_VALIDATE_BUG_ON(new_port->port < (*list)->last->port);
257                         (*list)->last->next = new_port;
258                         new_port->prev = (*list)->last;
259                         (*list)->last = new_port;
260                     } else {

The code does not generate two port ranges that are same other than the
cases where port == port2 which is why it worked so far. Fix it.

Bug 6839
src/util-port-interval-tree.c