]> git.ipfire.org Git - thirdparty/krb5.git/commit
Fix gss-krb5 handling of high sequence numbers 1175/head
authorGreg Hudson <ghudson@mit.edu>
Sat, 27 Mar 2021 04:52:05 +0000 (00:52 -0400)
committerGreg Hudson <ghudson@mit.edu>
Wed, 31 Mar 2021 06:00:19 +0000 (02:00 -0400)
commitdac8de0b26b9b67c1b03067c1ec90b81114ff370
treeb5747b3a8764559e6856802106dd39711cd4dfbd
parentae40b2eabb8954679e55f0ae79c3aaa96974fb40
Fix gss-krb5 handling of high sequence numbers

Commits abcfdaff756631d73f49103f679cafa7bc45f14e and
41ddaaeb286e8bb1bba64fb557ba0e4cff9b404d incorrectly changed the
interpretation of authenticator sequence numbers in the range
2^31..2^32-1, mapping them to sign-extended 64-bit values.  The major
Kerberos implementations do not generate sequence numbers this large,
so the changed went unnoticed.  Prevent unwanted sign extension by
casting sequence numbers retrieved from auth contexts to uint32_t
before assigning them to uint64_t fields.  Reported by Jake Scott.

ticket: 8994 (new)
src/lib/gssapi/krb5/accept_sec_context.c
src/lib/gssapi/krb5/init_sec_context.c