]> git.ipfire.org Git - thirdparty/suricata.git/commit
detect: don't set conflicting packet/flow actions 13222/head
authorVictor Julien <vjulien@oisf.net>
Tue, 13 May 2025 09:26:46 +0000 (11:26 +0200)
committerVictor Julien <vjulien@oisf.net>
Tue, 13 May 2025 09:26:46 +0000 (11:26 +0200)
commit8a329656098d8d0eca2f255924c0f117fc2dfe1f
tree7cdcc60a23d8ab17c043234e80ba8fbef4762226
parent155487e79d84d43b2d6bba7bde0870cca310bcbe
detect: don't set conflicting packet/flow actions

If for the same a packet a drop rule and a pass rule would match,
the applying of actions could be contradictionary:

- the drop would be applied to the packet
- the pass rule would also be considered, not overriding the drop,
  but still setting the flow pass flag.

This would lead to the packet being dropped, but the rest of the
flow getting passed, including retransmissions of the dropped
packet.

This patch only sets drop/pass actions if no conflicting action
has been set on the packet before. It respects the action-order.

Bug: #7653.

Fix based on:
57b17fb3b2fb ("detect: don't set conflicting packet/flow actions")
src/detect-engine-alert.c