]> git.ipfire.org Git - thirdparty/pdns.git/commit
dnsdist: Set proper levels when logging messages 13305/head
authorRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 28 Sep 2023 13:32:29 +0000 (15:32 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 28 Sep 2023 13:32:29 +0000 (15:32 +0200)
commitf8e1161f37e310279c635de0cc79c031b0e7e270
tree83a9fd65275abfc6e5cf33477e35e825b12fd1ed
parent598ddcb064acaf640f1437122461687f80cee053
dnsdist: Set proper levels when logging messages

This PR re-evaluates the log level of all messages in the DNSdist
code base. The rules are simple:
- 'Error' should only be used when a critical service will not function
  properly
- 'Warning' should be used when a non-essential feature may not be
  working as expected
- 'Info' is for everything that should not go unnoticed but also cannot
  be triggered by an outside attacker, otherwise we might be flooding
  our logs
- 'Verbose' can be used for everything else.

There are a few exceptions, something we log at the 'info' level for
events that might be happening a lot, but only when told to do so,
like for example with verbose health-check reporting.
12 files changed:
pdns/dnsdist-console.cc
pdns/dnsdist-lua.cc
pdns/dnsdist-tcp.cc
pdns/dnsdist-web.cc
pdns/dnsdist.cc
pdns/dnsdistdist/dnsdist-kvs.cc
pdns/dnsdistdist/dnsdist-lua-bindings-dnscrypt.cc
pdns/dnsdistdist/dnsdist-nghttp2-in.cc
pdns/dnsdistdist/dnsdist-nghttp2.cc
pdns/dnsdistdist/dnsdist-secpoll.cc
pdns/dnsdistdist/doh.cc
pdns/tcpiohandler.cc